From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net> |
Subject: | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
Date: | 2020-04-12 01:33:52 |
Message-ID: | 20200412013352.GA2491@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 07, 2020 at 03:44:06PM -0500, Justin Pryzby wrote:
> > I mean to literally use vac_analyze_option_list for reindex and cluster as
> > well. Please, check attached 0007. Now, vacuum, reindex and cluster filter
> > options list and reject everything that is not supported, so it seems
> > completely fine to just reuse vac_analyze_option_list, doesn't it?
>
> It's fine with me :)
>
> Possibly we could rename vac_analyze_option_list as generic_option_list.
>
> I'm resending the patchset like that, and fixed cluster/index to handle not
> just "VERBOSE" but "verbose OFF", rather than just ignoring the argument.
>
> That's the last known issue with the patch. I doubt anyone will elect to pick
> it up in the next 8 hours, but I think it's in very good shape for v14 :)
I tweaked some comments and docs and plan to mark this RfC.
--
Justin
Attachment | Content-Type | Size |
---|---|---|
v20-0001-tab-completion-for-reindex-verbose.patch | text/x-diff | 1.8 KB |
v20-0002-Change-REINDEX-CLUSTER-to-accept-an-option-list.patch | text/x-diff | 23.7 KB |
v20-0003-Allow-REINDEX-to-change-tablespace.patch | text/x-diff | 26.8 KB |
v20-0004-Allow-CLUSTER-and-VACUUM-FULL-to-change-tablespa.patch | text/x-diff | 23.5 KB |
v20-0005-Implement-vacuum-full-cluster-INDEX_TABLESPACE-t.patch | text/x-diff | 19.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-04-12 01:45:41 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
Previous Message | Jose Luis Tallon | 2020-04-12 00:38:23 | Re: where should I stick that backup? |