Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net>
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly
Date: 2020-04-03 18:27:12
Message-ID: 20200403182712.GR14618@telsasoft.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 01, 2020 at 08:08:36AM -0500, Justin Pryzby wrote:
> Or maybe you'd want me to squish my changes into yours and resend after any
> review comments ?

I didn't hear any feedback, so I've now squished all "parenthesized" and "fix"
commits. 0004 reduces duplicative error handling, as a separate commit so
Alexey can review it and/or integrate it. The last two commits save a few
dozen lines of code, but not sure they're desirable.

As this changes REINDEX/CLUSTER to allow parenthesized options, it might be
pretty reasonable if someone were to kick this to the July CF.

--
Justin

Attachment Content-Type Size
v17-0001-tab-completion-for-reindex-verbose.patch text/x-diff 1.8 KB
v17-0002-Change-REINDEX-CLUSTER-to-accept-an-option-list.patch text/x-diff 22.3 KB
v17-0003-Allow-REINDEX-to-change-tablespace.patch text/x-diff 31.5 KB
v17-0004-indexcmds-remove-redundant-checks.patch text/x-diff 5.9 KB
v17-0005-Allow-CLUSTER-and-VACUUM-FULL-to-change-tablespa.patch text/x-diff 24.1 KB
v17-0006-Implement-vacuum-full-cluster-INDEX_TABLESPACE-t.patch text/x-diff 18.0 KB
v17-0007-pass-idxtablespaceNAME-to-reduce-error-duplicati.patch text/x-diff 19.9 KB
v17-0008-Also-pass-the-table-s-tablespace-as-char.patch text/x-diff 10.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Anna Akenteva 2020-04-03 18:51:13 Re: [HACKERS] make async slave to wait for lsn to be replayed
Previous Message Bryn Llewellyn 2020-04-03 18:14:00 Re: Syntax rules for a text value inside the literal for a user-defined type—doc section “8.16.2. Constructing Composite Values”