| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Surafel Temesgen <surafel3000(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Subject: | Re: FETCH FIRST clause WITH TIES option |
| Date: | 2019-11-26 15:09:41 |
| Message-ID: | 20191126150941.GA4161@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I rebased this patch, and my proposed changes are in 0002.
Looking at the changes in ExecLimit, I'm wondering if it would be better
to add a new state to the state machine there -- instead of doing all
the work in duplicative code in the LIMIT_INWINDOW case, have that one
only save the current end-of-window tuple and jump to
LIMIT_WINDOWEND_WITH_TIE (or something) which then returns all tuples that
match the current one. I think that would end up being cleaner. Please
research.
Marking Waiting on Author.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v14-0001-v13.patch | text/x-diff | 35.6 KB |
| v14-0002-grammar-tweaks.patch | text/x-diff | 8.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-11-26 15:32:29 | Re: benchmarking Flex practices |
| Previous Message | v.makarov | 2019-11-26 14:59:25 | [PATCH] Increase the maximum value track_activity_query_size |