| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_wal/RECOVERYHISTORY file remains after archive recovery |
| Date: | 2019-09-30 08:03:40 |
| Message-ID: | 20190930080340.GO2888@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 30, 2019 at 12:53:58PM +0900, Masahiko Sawada wrote:
> I think that the above checks are always true because isnt() function
> checks if the 1st argument and 2nd argument are not the same.
Dammit. I overlooked this part of the module's doc.
> I've attached the updated version patch including the tests. Please
> review it.
Thanks, your test allows to reproduce the original problem, so that's
nice. I don't have much to say, except some improvements to the
comments of the test as per the attached. What do you think?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v6_remove_recovered_historyfile.patch | text/x-diff | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-09-30 08:07:08 | Re: pg_wal/RECOVERYHISTORY file remains after archive recovery |
| Previous Message | Andres Freund | 2019-09-30 08:00:20 | Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch |