From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Cache lookup errors with functions manipulation object addresses |
Date: | 2019-09-23 23:58:50 |
Message-ID: | 20190923235850.GA2012@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Sep 23, 2019 at 09:15:24PM +0200, Dmitry Dolgov wrote:
> Thanks for the patch! I couldn't check it in action, since looks like it
> doesn't apply anymore [1] (although after a quick check I'm not entirely sure
> why). Nevertheless I have a few short commentaries:
Thanks for the review. There was a small conflict in objectaddress.h
easy enough to solve.
> Here and in format_operator_extened commentary says
>
> * Returns a palloc'd string.
>
> but now it's possible to return NULL, so I guess comments need to be adjusted,
> right?
Right.
> v16-0003-Eliminate-user-visible-cache-lookup-errors-for-o.patch
>
> - appendStringInfo(&buffer, _("operator %s"),
> - format_operator(object->objectId));
> - break;
> + {
> + char *oprname = format_operator_extended(object->objectId,
> + FORMAT_PROC_FORCE_NULL);
>
> Shouldn't it be FORMAT_OPERATOR_FORCE_NULL here?
Indeed, that's the case.
Please feel free to use the updated versions attached. These can
apply on top of HEAD at 30d1379.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
v17-0001-Add-flag-to-format_type_extended-to-enforce-NULL.patch | text/x-diff | 3.7 KB |
v17-0002-Refactor-format-procedure-and-operator-APIs-to-b.patch | text/x-diff | 7.0 KB |
v17-0003-Eliminate-user-visible-cache-lookup-errors-for-o.patch | text/x-diff | 119.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tsunakawa, Takayuki | 2019-09-23 23:59:07 | RE: [bug fix??] Fishy code in tts_cirtual_copyslot() |
Previous Message | Alvaro Herrera from 2ndQuadrant | 2019-09-23 22:00:38 | Re: Attempt to consolidate reading of XLOG page |