Switch TAP tests of pg_rewind to use role with only function permissions

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Switch TAP tests of pg_rewind to use role with only function permissions
Date: 2019-04-11 04:13:36
Message-ID: 20190411041336.GM2728@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

Recent commit bfc80683 has added some documentation in pg_rewind about
the fact that it is possible to do the operation with a non-superuser,
assuming that this role has sufficient grant rights to execute the
functions used by pg_rewind.

Peter Eisentraut has suggested to have some tests for this kind of
user here:
https://www.postgresql.org/message-id/e1570ba6-4459-d9b2-1321-9449adaaef4c@2ndquadrant.com

Attached is a patch which switches all the TAP tests of pg_rewind to
do that. As of now, the tests depend on a superuser for everything,
and it seems to me that it makes little sense to make the tests more
pluggable by being able to switch the roles used on-the-fly (the
invocation of pg_rewind is stuck into RewindTest.pm) as a superuser
has no restrictions.

Any thoughts?
--
Michael

Attachment Content-Type Size
rewind-user-tap.patch text/x-diff 1.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-04-11 04:14:46 Re: pg_rewind vs superuser
Previous Message Mark Kirkwood 2019-04-11 04:08:14 Re: Zedstore - compressed in-core columnar storage