From: | Ildus Kurbangaliev <i(dot)kurbangaliev(at)gmail(dot)com> |
---|---|
To: | David Steele <david(at)pgmasters(dot)net> |
Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [HACKERS] Custom compression methods |
Date: | 2019-03-15 11:52:03 |
Message-ID: | 20190315125203.5da43edb@ildus-work.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 15 Mar 2019 14:07:14 +0400
David Steele <david(at)pgmasters(dot)net> wrote:
> On 3/7/19 11:50 AM, Alexander Korotkov wrote:
> > On Thu, Mar 7, 2019 at 10:43 AM David Steele <david(at)pgmasters(dot)net
> > <mailto:david(at)pgmasters(dot)net>> wrote:
> >
> > On 2/28/19 5:44 PM, Ildus Kurbangaliev wrote:
> >
> > > there are another set of patches.
> > > Only rebased to current master.
> > >
> > > Also I will change status on commitfest to 'Needs review'.
> >
> > This patch has seen periodic rebases but no code review that I
> > can see since last January 2018.
> >
> > As Andres noted in [1], I think that we need to decide if this
> > is a feature that we want rather than just continuing to push it
> > from CF to CF.
> >
> >
> > Yes. I took a look at code of this patch. I think it's in pretty
> > good shape. But high level review/discussion is required.
>
> OK, but I think this patch can only be pushed one more time, maximum,
> before it should be rejected.
>
> Regards,
Hi,
in my opinion this patch is usually skipped not because it is not
needed, but because of its size. It is not hard to maintain it until
commiters will have time for it or I will get actual response that
nobody is going to commit it.
Attached latest set of patches.
--
Best regards,
Ildus Kurbangaliev
Attachment | Content-Type | Size |
---|---|---|
0001-Make-syntax-changes-for-custom-compression-metho-v22.patch | text/x-patch | 8.6 KB |
0002-Add-compression-catalog-tables-and-the-basic-inf-v22.patch | text/x-patch | 113.7 KB |
0003-Add-rewrite-rules-and-tupdesc-flags-v22.patch | text/x-patch | 24.3 KB |
0004-Add-pglz-compression-method-v22.patch | text/x-patch | 7.6 KB |
0005-Add-zlib-compression-method-v22.patch | text/x-patch | 10.0 KB |
0006-Add-psql-pg_dump-and-pg_upgrade-support-v22.patch | text/x-patch | 34.4 KB |
0007-Add-tests-for-compression-methods-v22.patch | text/x-patch | 153.4 KB |
0008-Add-documentation-for-custom-compression-methods-v22.patch | text/x-patch | 17.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Banck | 2019-03-15 11:54:01 | Re: Offline enabling/disabling of data checksums |
Previous Message | Bruno Hass | 2019-03-15 11:37:40 | RE: Best way to keep track of a sliced TOAST |