From: | Christoph Berg <christoph(dot)berg(at)credativ(dot)de> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well |
Date: | 2019-01-07 09:17:34 |
Message-ID: | 20190107091734.GA1582@msg.credativ.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Re: Michael Paquier 2019-01-04 <20190104133305(dot)GG2067(at)paquier(dot)xyz>
> On Fri, Jan 04, 2019 at 11:41:15AM +0100, Peter Eisentraut wrote:
> > Note that pgxs supports PG_CPPFLAGS for adding custom pieces to CPPFLAGS
> > in a safe way. Maybe we should add an equivalent for CFLAGS? It's just
> > that it hasn't been needed so far.
>
> +1. Wouldn't it make sense to also have PG_LDFLAGS? In some stuff I
> maintain, I have been abusing of PG_CPPFLAGS to pass some flags, which
> is not really right. We also have contrib/passwordcheck/Makefile
> abuse of it to set -DUSE_CRACKLIB..
I'll buy whatever version that works. I'm using CFLAGS at the moment,
but could easily switch to other variables.
Note that the missing bit here is the CXX part, adding PG_CFLAGS alone
wouldn't help.
Updated patch attached.
Christoph
--
Senior Berater, Tel.: +49 2166 9901 187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz
Attachment | Content-Type | Size |
---|---|---|
0001-Add-more-flexibility-for-passing-custom-compiler-fla.patch | text/x-diff | 2.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Christoph Berg | 2019-01-07 09:32:20 | Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well |
Previous Message | Amit Langote | 2019-01-07 09:17:07 | Re: speeding up planning with partitions |