From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
Cc: | Edmund Horner <ejrh00(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: adding tab completions |
Date: | 2018-07-30 00:42:43 |
Message-ID: | 20180730004243.GE3222@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Sorry for the delay..this got lost while catching up after being out of town..
On Thu, Jun 28, 2018 at 02:20:39PM +0300, Arthur Zakirov wrote:
> Thank you for the new version.
>
> On Wed, Jun 27, 2018 at 03:10:51PM -0500, Justin Pryzby wrote:
> > Thanks - I've done this in the attached. It works well for having minimal
> > logic.
>
> I think everthing is OK. But I didn't notice in previous version of the
> patch that there is no braces in EXPLAIN and VACUUM conditions. I attached
> diff file to show it.
>
> Also I included TEXT, XML, JSON, YAML items for FORMAT option in the
> diff file. The patch shows ",", ")", "ON", "OFF" for all options, but
> FORMAT requires format type to be specified. Please consider this change
> only as a suggestion.
Your suggestion is good, so attached updated patch.
> > Actually..another thought: since toast tables may be VACUUM-ed, should I
> > introduce Query_for_list_of_tpmt ?
I didn't include this one yet though.
Feel free to bump to next CF.
Justin
Attachment | Content-Type | Size |
---|---|---|
v11-tab-complete-partitions | text/plain | 6.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2018-07-30 01:34:29 | Re: Usability fail with psql's \dp command |
Previous Message | Michael Paquier | 2018-07-30 00:34:22 | Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack |