From: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Missing checks when malloc returns NULL... |
Date: | 2016-08-29 13:05:14 |
Message-ID: | 20160829130513.GA8340@e733 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello, Michael
> I don't know how you did it, but this email has visibly broken the
> original thread. Did you change the topic name?
I'm very sorry for this. I had no local copy of this thread. So I wrote a
new email with the same subject hoping it will be OK. Apparently right
In-Reply-To header is also required.
> if (prodesc->user_proname == NULL || prodesc->internal_proname == NULL)
> + {
> + free(prodesc);
I think that prodesc->user_proname and prodesc->internal_proname should
also be freed if they are not NULL's.
> By the way maybe someone knows other procedures besides malloc, realloc
> and strdup that require special attention?
I recalled that there is also calloc(). I've found four places that use
calloc() and look suspicious to me (see attachment). What do you think -
are these bugs or not?
--
Best regards,
Aleksander Alekseev
Attachment | Content-Type | Size |
---|---|---|
calloc.txt | text/plain | 3.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Verite | 2016-08-29 13:42:31 | Re: Renaming of pg_xlog and pg_clog |
Previous Message | Craig Ringer | 2016-08-29 12:39:05 | Re: Renaming of pg_xlog and pg_clog |