Re: Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)

From: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
To: Chapman Flack <chap(at)anastigmatix(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)
Date: 2016-03-21 14:21:15
Message-ID: 20160321172115.2a9d84f1@fujitsu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Well, the documentation already says to avoid it:
>
> http://www.postgresql.org/docs/current/static/xfunc-c.html
>
> Another important point is to avoid leaving any uninitialized
> bits within data type values; for example, take care to zero out
> any alignment padding bytes that might be present in structs.
>
> so I don't think what you're suggesting would be controversial
> at all; it looks like what you've done is found a(t least one)
> bug where the documented practice wasn't followed, and it's good
> to find any such places.

Well in this case here is a patch that fixes "use of uninitialized
value" reports by MemorySanitizer I managed to catch so far.

--
Best regards,
Aleksander Alekseev
http://eax.me/

Attachment Content-Type Size
use-of-uninitialized-value-fix.diff text/x-patch 7.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2016-03-21 14:32:00 Re: Postgres_fdw join pushdown - getting server crash in left outer join of three table
Previous Message Petr Jelinek 2016-03-21 14:14:43 Re: Proposal: Generic WAL logical messages