From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
Cc: | hlinnaka(at)iki(dot)fi, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch to improve a few appendStringInfo* calls |
Date: | 2015-07-02 13:45:09 |
Message-ID: | 20150702134509.GK3289@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
David Rowley wrote:
> On 2 July 2015 at 21:59, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> > I left out the changes like
> >
> > - appendStringInfoString(&collist, buf.data);
> >> + appendBinaryStringInfo(&collist, buf.data, buf.len);
> >>
> >
> > because they're not an improvement in readablity, IMHO, and they were not
> > in performance-critical paths.
> >
> Perhaps we can come up with appendStringInfoStringInfo at some later date.
I had this exact thought when I saw your patch (though it was
appendStringInfoSI to me because the other name is too long and a bit
confusing). It seems straightforward enough ...
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2015-07-02 13:45:25 | Re: WALWriter active during recovery |
Previous Message | Simon Riggs | 2015-07-02 13:43:42 | Re: raw output from copy |