From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
---|---|
To: | <fabriziomello(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, "[pgdg] Robert Haas" <robertmhaas(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Minimal logical decoding on standbys |
Date: | 2021-02-04 16:49:23 |
Message-ID: | 1ab609c9-2c16-26ff-5fbe-c3195e541f9c@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 1/26/21 10:31 AM, Drouvot, Bertrand wrote:
>
> Hi,
>
> On 1/25/21 8:34 PM, Fabrízio de Royes Mello wrote:
>>
>> On Mon, Jan 18, 2021 at 8:48 AM Drouvot, Bertrand
>> <bdrouvot(at)amazon(dot)com <mailto:bdrouvot(at)amazon(dot)com>> wrote:
>> >
>> > 3 and 4 were failing because the
>> ResolveRecoveryConflictWithLogicalSlots() call was missing in
>> ResolveRecoveryConflictWithSnapshot(): the new version attached adds it.
>> >
>> > The new version attached also provides a few changes to make it
>> compiling on the current master (it was not the case anymore).
>> >
>> > I also had to change 023_standby_logical_decoding_conflicts.pl
>> <http://023_standby_logical_decoding_conflicts.pl> (had to call
>> $node_standby->create_logical_slot_on_standby($node_master,
>> 'otherslot', 'postgres'); at the very beginning of the "DROP DATABASE
>> should drops it's slots, including active slots" section)
>> >
>>
>> Awesome and thanks a lot.
>>
>> Seems your patch series is broken... can you please `git
>> format-patch` and send again?
>
> Thanks for pointing out!
>
> Enclosed a new series created with "format-patch" and that can be
> applied with "git am":
>
> $ git am v8-000*.patch
> Applying: Allow logical decoding on standby.
> Applying: Add info in WAL records in preparation for logical slot
> conflict handling.
> Applying: Handle logical slot conflicts on standby.
> Applying: New TAP test for logical decoding on standby.
> Applying: Doc changes describing details about logical decoding.
>
> Bertrand
>
Had to do a little change to make it compiling again (re-add the heapRel
argument in _bt_delitems_delete() that was removed by commit
dc43492e46c7145a476cb8ca6200fc8eefe673ef).
Given that this attached v9 version:
* compiles successfully on current master
* passes "make check"
* passes the 2 associated tap tests "make -C src/test/recovery check
PROVE_TESTS=t/022_standby_logical_decoding_xmins.pl PROVE_FLAGS=-v"
and "make -C src/test/recovery check
PROVE_TESTS=t/023_standby_logical_decoding_conflicts.pl PROVE_FLAGS=-v"
wouldn't that make sense to (re)add this patch in the commitfest?
Thanks
Bertrand
Attachment | Content-Type | Size |
---|---|---|
v9-0001-Allow-logical-decoding-on-standby.patch | text/plain | 9.4 KB |
v9-0002-Add-info-in-WAL-records-in-preparation-for-logica.patch | text/plain | 19.6 KB |
v9-0003-Handle-logical-slot-conflicts-on-standby.patch | text/plain | 25.3 KB |
v9-0004-New-TAP-test-for-logical-decoding-on-standby.patch | text/plain | 20.5 KB |
v9-0005-Doc-changes-describing-details-about-logical-deco.patch | text/plain | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2021-02-04 16:49:35 | Re: Is Recovery actually paused? |
Previous Message | Dilip Kumar | 2021-02-04 16:39:32 | Re: [HACKERS] Custom compression methods |