Re: Idea: closing the loop for "pg_ctl reload"

From: Jan de Visser <jan(at)de-visser(dot)net>
To: Payal Singh <payal(at)omniti(dot)com>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>
Subject: Re: Idea: closing the loop for "pg_ctl reload"
Date: 2015-04-22 02:23:23
Message-ID: 1980322.vj5l7qtcl0@wolverine
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On April 21, 2015 09:34:51 PM Jan de Visser wrote:
> On April 21, 2015 09:01:14 PM Jan de Visser wrote:
> > On April 21, 2015 07:32:05 PM Payal Singh wrote:
... snip ...
>
> Urgh. It appears you are right. Will fix.
>
> jan

Attached a new attempt. This was one from the category 'I have no idea how
that ever worked", but whatever. For reference, this is how it looks for me
(magic man-behind-the-curtain postgresql.conf editing omitted):

jan(at)wolverine:~/Projects/postgresql$ initdb -D data
... Bla bla bla ...
jan(at)wolverine:~/Projects/postgresql$ pg_ctl -D data -l logfile start
server starting
jan(at)wolverine:~/Projects/postgresql$ tail -5 logfile
LOG: database system was shut down at 2015-04-21 22:03:33 EDT
LOG: database system is ready to accept connections
LOG: autovacuum launcher started
jan(at)wolverine:~/Projects/postgresql$ pg_ctl -D data reload
server signaled
jan(at)wolverine:~/Projects/postgresql$ tail -5 logfile
LOG: database system was shut down at 2015-04-21 22:03:33 EDT
LOG: database system is ready to accept connections
LOG: autovacuum launcher started
LOG: received SIGHUP, reloading configuration files
jan(at)wolverine:~/Projects/postgresql$ pg_ctl -D data reload
server signaled
pg_ctl: Reload of server with PID 14656 FAILED
Consult the server log for details.
jan(at)wolverine:~/Projects/postgresql$ tail -5 logfile
LOG: autovacuum launcher started
LOG: received SIGHUP, reloading configuration files
LOG: received SIGHUP, reloading configuration files
LOG: syntax error in file "/home/jan/Projects/postgresql/data/postgresql.conf"
line 1, near end of line
LOG: configuration file "/home/jan/Projects/postgresql/data/postgresql.conf"
contains errors; no changes were applied
jan(at)wolverine:~/Projects/postgresql$

Attachment Content-Type Size
Let_pg_ctl_check_the_result_of_a_postmaster_config_reload.patch text/x-patch 9.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2015-04-22 02:33:50 Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)
Previous Message Jan de Visser 2015-04-22 01:34:51 Re: Idea: closing the loop for "pg_ctl reload"