| From: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Subject: | Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead |
| Date: | 2019-01-20 10:35:55 |
| Message-ID: | 1921952.xWjPjWaBPZ@x200m |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
В письме от четверг, 17 января 2019 г. 20:33:06 MSK пользователь Alvaro
Herrera написал:
> You introduced new macros IsHeapRelation and IsViewRelation, but I don't
> want to introduce such API. Such things have been heavily contested and
> I don't to have one more thing to worry about for this patch, so please
> just put the relkind directly in the code.
Sorry.
I've been trying to avoid repeating
(AssertMacro(relation->rd_rel->relkind == RELKIND_RELATION || \
relation->rd_rel->relkind == RELKIND_MATVIEW), \
all the time.
Fixed.
Also I make more relaxed parallel_workers behavior in get_relation_info as we
discussed in another thread.
| Attachment | Content-Type | Size |
|---|---|---|
| get-rid-of-StrRdOptions_4.diff | text/x-patch | 35.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-01-20 11:35:20 | Re: Alternative to \copy in psql modelled after \g |
| Previous Message | Fabien COELHO | 2019-01-20 10:07:46 | Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD |