From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Joe Conway <joe(at)crunchydata(dot)com> |
Subject: | Re: Granting SET and ALTER SYSTE privileges for GUCs |
Date: | 2022-03-28 20:57:50 |
Message-ID: | 18A291A8-362E-4AB1-833D-66410751E401@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Mar 28, 2022, at 12:11 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> writes:
>> Version 12 also introduces \dcp (pneumonic, "Describe Configuration Parameter") for listing parameters, with \dcp+ also showing the acl, like:
>
> The fact that that code is not dry behind the ears is painfully obvious.
<snip>
> On the whole perhaps this should be taken out again
I added the \dcp command after noticing that doc/src/sgml/ddl.sgml's "Summary of Access Privileges" table had an empty column for the "psql Command" column for the "PARAMETER" row. Maybe that's ok. I thought it would be better if I added a command for that.
I don't feel too strongly about it, so I'm removing \dcp from this patch with the intention of introducing it as a separate patch for the postgres 16 development cycle. For now, I'm just putting "none" in that table cell.
This patch also moves the grant/revoke tests in guc_privs.sql into the unsafe_tests directory, fixes them up to be repeatable, and drops the superuser role that had been negligently left around in prior patches. The tests that had been added in privileges.sql are simply removed.
Attachment | Content-Type | Size |
---|---|---|
v13-0001-Allow-grant-and-revoke-of-privileges-on-paramete.patch | application/octet-stream | 129.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-03-28 21:16:14 | Re: Granting SET and ALTER SYSTE privileges for GUCs |
Previous Message | Justin Pryzby | 2022-03-28 20:53:29 | Re: refactoring basebackup.c (zstd workers) |