Re: [PATCH] Add array_reverse() function

From: Vladlen Popolitov <v(dot)popolitov(at)postgrespro(dot)ru>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Aleksander Alekseev <afiskon(at)gmail(dot)com>
Subject: Re: [PATCH] Add array_reverse() function
Date: 2024-10-31 06:37:31
Message-ID: 173035665129.1164.3833125953041709640.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation: tested, failed

Content.
The proposed function waited long to be implemented and it will be very
useful. Personally I used slow workaround, when I needed the reverse of
the array.

Run.
This patch applies cleanly to HEAD. All regression tests pass
successfully against the patch.

Format.
The code formatted according to The Code Guidelines

Documentation.
The documentation is updated, the description of the function is added.
From my point of view, it would be better to mention, that function returns
updated array (does not updates it in place, as a reader can understand),
but other array returning functions in the documentation has the same
style (silently assume: reverse == return reversed array).

Conclusion.
+1 for commiter review

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2024-10-31 08:01:30 Re: In-placre persistance change of a relation
Previous Message Michael Paquier 2024-10-31 06:32:39 Re: Consider pipeline implicit transaction as a transaction block