From: | Hans Buschmann <buschmann(at)nidsa(dot)net> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | AW: VS2022: Support Visual Studio 2022 on Windows |
Date: | 2021-11-20 17:54:30 |
Message-ID: | 1637430878313.67066@nidsa.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Daniel,
Thank you for looking into it.
My skills with git are minmal yet and I am working on a correct development platform, so sorry for any inconveniances from my side .
When upgraded Microsoft jumped directly from Preview 7 to Preview 7.1 of VS2022 by skipping the release version of 7.0.
I had to install it on a different machine to test it with the final VS2022 version from november 8.
On both platforms the build of snapshot from 19.11.2021 is successfull but gives the following warnings which seem not correlated to the proposed patch:
Der Buildvorgang wurde erfolgreich ausgeführt.
"C:\pgdev\postgresql-15devel\pgsql.sln" (Standardziel) (1) ->
"C:\pgdev\postgresql-15devel\postgres.vcxproj" (Standardziel) (2) ->
(ClCompile Ziel) ->
C:\pgdev\postgresql-15devel\src\backend\access\heap\pruneheap.c(858,18): warning C4101: "htup": Unreferenzierte lokale Variable [C:\pgdev\postgresql-15devel\postgres.vcxproj]
C:\pgdev\postgresql-15devel\src\backend\access\heap\pruneheap.c(870,11): warning C4101: "tolp": Unreferenzierte lokale Variable [C:\pgdev\postgresql-15devel\postgres.vcxproj]
2 Warnung(en)
0 Fehler
(Meaning 2 unreferenced local variables in pruneheap.c)
The build produced .vcxproj files with ToolsVersion="17.0", so it recognized the new environment correctly.
I corrected some ommissions in _GetVisualStudioVersion in VSObjectFactory.pm.
Please find attached the corrected patch version v4.
Due to my restricted devlopment environment I appreciate if anybody can test the resulting binaries (but MS seems not have changed much on the C Build environment internally).
Thanks
Hans Buschmann
Attachment | Content-Type | Size |
---|---|---|
0001_support_vs2022_v4.patch | application/octet-stream | 8.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2021-11-20 18:13:45 | Re: Feature Proposal: Connection Pool Optimization - Change the Connection User |
Previous Message | Andrey Borodin | 2021-11-20 17:27:28 | Re: Feature Proposal: Connection Pool Optimization - Change the Connection User |