| From: | MyungKyu LIM <myungkyu(dot)lim(at)samsung(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Woosung Sohn <woosung(dot)sohn(at)samsung(dot)com>, DoHyung HONG <don(dot)hong(at)samsung(dot)com> |
| Subject: | FW: [Todo item] Add entry creation timestamp column to pg_stat_replication |
| Date: | 2018-08-02 09:33:51 |
| Message-ID: | 1459102727.630179.1533202431977.JavaMail.jboss@ep2ml404 |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I changed field name from 'reply_time' to 'last_msg_send_time'.
Because 'last_msg_send_time' is used in pg_stat_wal_receiver/pg_stat_subsctiption view.
I think that field has the same meaning.
test example>
postgres=# select pid, last_msg_send_time from pg_stat_replication;
-[ RECORD 1 ]------+------------------------------
pid | 12015
last_msg_send_time | 2018-08-02 18:02:49.233049+09
-[ RECORD 2 ]------+------------------------------
pid | 12084
last_msg_send_time | 2018-08-02 18:02:48.583256+09
I Attached new patch file : 0001-Implement-following-TODO-list-item-v2.patch
Feedback and suggestion will be very welcome.
Thanks!
Best regards,
Myungkyu, Lim
--------- Original Message ---------
Date : 2018-07-31 17:56 (GMT+9)
Title : [Todo item] Add entry creation timestamp column to pg_stat_replication
Hello hackers,
I have worked on following todo list item.
- Add entry creation timestamp column to pg_stat_replication
http://archives.postgresql.org/pgsql-hackers/2011-08/msg00694.php
This item looks like simple because necessary data was already exist.
So, I wrote a prototype patch.
test example>
postgres=# select pid, reply_time from pg_stat_replication;
-[ RECORD 1 ]-----------------------------
pid | 4817
reply_time | 2018-07-31 12:00:53.911198+09
-[ RECORD 2 ]-----------------------------
pid | 4819
reply_time | 2018-07-31 12:00:53.911154+09
Several candidates exist for the field name.
- reply_timestamp
- info_gen_timestamp
- stats_reset
- last_msg_send_time
Feedback and suggestion will be very welcome.
Thanks!
Best regards,
Myungkyu, Lim
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Implement-following-TODO-list-item-v1.patch | application/octet-stream | 7.2 KB |
| 0001-Implement-following-TODO-list-item-v2.patch | application/octet-stream | 7.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrien NAYRAT | 2018-08-02 09:41:33 | Re: [HACKERS] Parallel Append implementation |
| Previous Message | Simon Riggs | 2018-08-02 08:05:06 | Re: patch to ensure logical decoding errors early |