| From: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
|---|---|
| To: | Chapman Flack <jcflack(at)acm(dot)org> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Subject: | Re: Shouldn't jsonpath .string() Unwrap? |
| Date: | 2024-06-14 16:03:54 |
| Message-ID: | 12E14B60-2C7C-4CB2-9ECE-449F6D866D50@justatheory.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jun 14, 2024, at 11:25, Chapman Flack <jcflack(at)acm(dot)org> wrote:
>
> I would s/extepsions/exceptions/ in the added documentation. :)
Bah, fixed and attached, thanks.
> Offhand (as GitHub PRs aren't really The PG Way), if they were The Way,
> I would find this one a little hard to follow, being based at a point
> 28 unrelated commits ahead of the ref it's opened against. I suspect
> 'master' on theory/postgres could be fast-forwarded to f1affb6 and then
> the PR would look much more approachable.
Yeah, I pushed the PR and branch before I synced master, and GitHub was taking a while to notice and update the PR. I fixed it with `git commit --all --amend --date now --reedit-message HEAD` and force-pushed (then fixed the typo and fixed again).
D
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Teach-jsonpath-string-to-unwrap-in-lax-mode.patch | application/octet-stream | 4.0 KB |
| unknown_filename | text/plain | 2 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-06-14 16:11:11 | Re: RFC: adding pytest as a supported test framework |
| Previous Message | Andres Freund | 2024-06-14 16:02:01 | Re: libpq contention due to gss even when not using gss |