Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, steven(dot)winfield(at)cantabcapital(dot)com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes
Date: 2020-01-23 16:09:36
Message-ID: 11000.1579795776@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2020-01-14 02:38, Tom Lane wrote:
>> On reflection, it seems like the best bet for the moment is to
>> remove double-quote from the rl_completer_quote_characters string,
>> which should restore all behavior around double-quoted strings to
>> what it was before. (We have to keep single-quote in that string,
>> though, or quoted file names fail entirely.)

> This patch (version 6) looks good to me.

Thanks for reviewing! Pushed, now we'll see what the buildfarm thinks...

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2020-01-23 17:14:23 Re: DROP OWNED CASCADE vs Temp tables
Previous Message selva kumar 2020-01-23 15:52:12 RE: Query will execute when inner query have issue

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-01-23 16:15:23 Re: Allow to_date() and to_timestamp() to accept localized names
Previous Message Alvaro Herrera 2020-01-23 15:55:52 Re: Allow to_date() and to_timestamp() to accept localized names