Re: Collation & ctype method table, and extension hooks

On 12/5/24 1:21 AM, Jeff Davis wrote:
>> = v9-0003-Move-code-for-collation-version-into-provider-spe.patch
>>
>> Moves some code from pg_collate.c into provider specific files.
>
> I agree with the general idea, but it seems we are accumulating a lot
> of provider-specific functions. Should we define a provider struct with
> its own methods?
>
> That would be a good step toward making the provider catalog-driven.
> Even if we don't support CREATE LOCALE PROVIDER, having space in the
> catalog would be a good place to track the provider version.

Yeah, that was my idea too but I just have not gotten around to it yet.

>> = v9-0004-Move-ICU-database-encoding-check-into-validation-.patch
>
> This seems to be causing a test failure in 020_createdb.pl.

Thanks, I have attached a fixup commit for this.

Andreas