Remove non-fast promotion Re: Should we remove a fallback promotion? take 2

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Remove non-fast promotion Re: Should we remove a fallback promotion? take 2
Date: 2020-04-20 06:26:16
Message-ID: 0b941eed-da2e-b69b-065e-806ccc4f2613@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/03/10 6:56, Andres Freund wrote:
> Hi,
>
> On 2020-03-06 16:33:18 -0300, Alvaro Herrera wrote:
>> On 2020-Mar-06, Michael Paquier wrote:
>>> On Thu, Mar 05, 2020 at 09:40:54AM -0500, Robert Haas wrote:
>>>> Seems reasonable, but it would be better if people proposed these
>>>> kinds of changes closer to the beginning of the release cycle rather
>>>> than in the crush at the end.
>>>
>>> +1, to both points.
>>
>> Why? Are you saying that there's some actual risk of breaking
>> something? We're not even near beta or feature freeze yet.
>>
>> I'm not seeing the reason for the "please propose this sooner in the
>> cycle" argument. It has already been proposed sooner -- seven years
>> sooner. We're not waiting for users to complain anymore; clearly nobody
>> cared.
>
> Yea. There are changes that are so invasive that it's useful to go very
> early, but in this case I'm not seeing it?
>
> +1 for removing non-fast promotions.

Patch attached. I will add this into the first CF for v14.

> FWIW, I find "fallback promotion" a confusing description.

Yeah, so I changed the subject.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
drop_non_fast_promotion_v1.patch text/plain 5.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2020-04-20 06:34:44 Re: fixing old_snapshot_threshold's time->xid mapping
Previous Message Fujii Masao 2020-04-20 06:05:46 Re: Race condition in SyncRepGetSyncStandbysPriority