| From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | 'Michael Paquier' <michael(at)paquier(dot)xyz> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: [bug fix] pg_rewind takes long time because it mistakenly copies data files |
| Date: | 2018-02-28 06:58:08 |
| Message-ID: | 0A3221C70F24FB45833433255569204D1F8D92DD@G01JPEXMBYT05 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Michael Paquier [mailto:michael(at)paquier(dot)xyz]
> So I would propose to just do that later. I have looked a second time at
> your patch, attached is the set of tests I have run:
Thanks so much, that has helped me a lot!
> I have one small comment though. The comment block at the beginning of
> isRelDataFile() refers to "pg_tblspc/<tblspc oid>/PG_9.4_201403261/".
> Could you switch that to "pg_tblspc/<tblspc oid>/<tblspc version>"?
> That's not directly the fault of your patch, but as long as we are on it..
Done, thanks again for marking the CF entry.
Regards
Takayuki Tsunakawa
| Attachment | Content-Type | Size |
|---|---|---|
| pg_rewind_pathcmp_v2.patch | application/octet-stream | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rajkumar Raghuwanshi | 2018-02-28 07:08:03 | Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key |
| Previous Message | Michael Paquier | 2018-02-28 06:13:31 | Re: [bug fix] pg_rewind takes long time because it mistakenly copies data files |