Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Vladlen Popolitov <v(dot)popolitov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Kane <andrew(at)ankane(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows
Date: 2024-12-25 17:25:18
Message-ID: 077756d1-c6af-4a59-a3f8-5f152ddabd08@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25/12/2024 18:34, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> Ok, committed that, thanks1
>
> The question this patch brings to my mind is whether libpgport
> doesn't need the same treatment.

Good point. Yes it does.

I tested that by adding a dummy call to COMP_CRC32C() in a test module,
and letting cirrus CI build it:

[17:10:32.715] dummy_index_am.c.obj : error LNK2001: unresolved external
symbol pg_comp_crc32c

Committed the same fix for libpqport.

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2024-12-25 17:25:50 Re: PoC: history of recent vacuum/checkpoint runs (using new hooks)
Previous Message Tomas Vondra 2024-12-25 16:52:51 Re: Parallel heap vacuum