Re: RFC: Allow EXPLAIN to Output Page Fault Information

From: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
To: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
Cc: andres(at)anarazel(dot)de, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org, rjuju123(at)gmail(dot)com, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: RFC: Allow EXPLAIN to Output Page Fault Information
Date: 2025-04-11 13:18:06
Message-ID: 0310f2ff46d990485f96624ac1744c01@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-03-25 10:27, torikoshia wrote:
> On 2025-03-22 20:23, Jelte Fennema-Nio wrote:
>
>> On Wed, 19 Mar 2025 at 14:15, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
>> wrote:
>>> BTW based on your discussion, I thought this patch could not be
>>> merged
>>> anytime soon. Does that align with your understanding?
>>
>> Yeah, that aligns with my understanding. I don't think it's realistic
>> to get this merged before the code freeze, but I think both of the
>> below issues could be resolved.
>>
>>> - With bgworker-based AIO, this patch could mislead users into
>>> underestimating the actual storage I/O load, which is undesirable.
>>
>> To resolve this, I think the patch would need to change to not report
>> anything if bgworker-based AIO is used.
>
> Agreed.
> I feel the new GUC io_method can be used to determine whether
> bgworker-based AIO is being used.

I took this approach and when io_method=worker, no additional output is
shown in the attached patch.

--
Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.

Attachment Content-Type Size
v4-0001-Add-storage-I-O-tracking-to-BUFFERS-option.patch text/x-diff 71.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Maksim Milyutin 2025-04-11 13:26:36 COALESCE with single argument looks like identity function
Previous Message Daniel Gustafsson 2025-04-11 13:08:30 Re: add some more error checks into _fileExistsInDirectory function to report "too long name" error