Beginner hacker item: Fix to_reg*() input type

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Beginner hacker item: Fix to_reg*() input type
Date: 2016-01-04 20:46:24
Message-ID: 568ADA20.7090205@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

All the to_reg* functions in src/backend/utils/adt/regproc.c currently
accept a cstring. Per [1], they should accept text. This should be a
fairly simple change to make:

- Modify the functions in regproc.c. Take a look at how other text input
functions work to see what needs to happen here (you'll want to use
text_to_cstring() as part of that.)

- Modify the appropriate entries in src/include/catalog/pg_proc.h

[1] http://www.postgresql.org/message-id/29618.1451882238@sss.pgh.pa.us.
Note that I mistakenly referred to reg*in functions in that email; it's
the to_reg* functions that need to change.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-01-04 20:48:12 Re: custom function for converting human readable sizes to bytes
Previous Message Alvaro Herrera 2016-01-04 20:44:19 Re: ALTER TABLE behind-the-scenes effects' CONTEXT