From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
Cc: | "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql(at)j-davis(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: new compiler warnings |
Date: | 2011-10-18 21:25:05 |
Message-ID: | 24446.1318973105@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't think the assert is a good idea. If it ever did happen,
>> that would promote the problem from "corrupted data in the log" to
>> "database crash".
> ... on a --enable-cassert build.
> If we think it's even remotely possible that it could happen, maybe
> we should do the loop. That would change the current "missing log
> information" situation to "interleaved log information".
The logging protocol is hosed either way.
> But if we think it would be better for data to be missing from the
> log than interleaved, the Assert could be removed and it still
> suppresses the error (at least on my machine).
As far as getting rid of the compiler warning is concerned, I find that
the
rc = write(...);
(void) rc;
suggestion works for me (gcc 4.6.1). I'm inclined to do that (and
document why) rather than put in looping code that will not make
anything better.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2011-10-18 21:44:47 | Re: new compiler warnings |
Previous Message | Tom Lane | 2011-10-18 21:18:18 | Re: termination of backend waiting for sync rep generates a junk log message |