| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers(at)postgreSQL(dot)org, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Subject: | Re: [COMMITTERS] pgsql: Centralize definition of integer limits. |
| Date: | 2015-03-31 14:14:23 |
| Message-ID: | 20150331141423.GK4878@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2015-03-30 21:50:09 +0200, Andres Freund wrote:
> I'm too fried from the redeye back from pgconf nyc to do anything
> complicated, but it seems quite possible to define int64/uint64 based
> the stdint.h types if available. And generally a good idea too. I guess
> I'll try that tomorrow; unless Andrew beats me to it.
It's possible to do that, but it's not as trivial as I'd hoped. For one
we'd need to include stdint.h in some places we don't today
(postgres_ext.h), for another we'd need some uglyness to determine the
correct printf modifier for int64_t (can't use PRId64 etc afaics).
I'm tempted to just prefix our limits with PG_ and define them
unconditionally, including appropriate casts to our types.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2015-03-31 14:26:49 | pgsql: btree_gin: properly call DirectFunctionCall1() |
| Previous Message | Heikki Linnakangas | 2015-03-31 12:23:33 | pgsql: Remove spurious semicolons. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2015-03-31 14:19:04 | Re: Streaming replication |
| Previous Message | Peter Geoghegan | 2015-03-31 14:02:55 | Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0 |