| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | \crosstabview fixes |
| Date: | 2016-04-13 17:45:15 |
| Message-ID: | 10276.1460569515@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I noticed that the \crosstabview documentation asserts that column name
arguments are handled per standard SQL semantics. In point of fact,
though, the patch expends a couple hundred lines to implement what is
NOT standard SQL semantics: matching unquoted names case-insensitively
is anything but that. I think we should rip all that out and do it as
per attached. (I also took the trouble to make the error messages conform
to project style.)
Comments/objections?
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| crosstabview-fixes.patch | text/x-diff | 18.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-13 17:49:18 | Re: SET ROLE and reserved roles |
| Previous Message | Robert Haas | 2016-04-13 17:36:09 | Re: Odd system-column handling in postgres_fdw join pushdown patch |